-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-5599][Juju 3.6] Break PR/worflow & nightly tests + DPW update #467
Conversation
Updates the data platform workflow to the latest version: 22.0.0. Breaks the ci.yaml file into workflow.yaml, for PRs and workflows; and nightly.yaml for the CI runs at night.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
PR description appears to be outdated
Breaks the ci.yaml file into workflow.yaml, for PRs and workflows; and nightly.yaml for the CI runs at night.
I would not recommend that approach—the approach currently in the PR is recommended instead
We should stay with pinned juju agent + a renovate config to bump this version, as described here: #470 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remember to remove build wrapper from tox.ini
full migration instructions: https://github.com/canonical/data-platform-workflows/releases/tag/v22.0.0
also please update dpw in pyproject.toml—compatibility only guaranteed if every dpw is on the same version (fyi, the renovate preset can take care of this for you) |
1bfde76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updates the data platform workflow to the latest version: 22.0.0.
Breaks down the integration tests between 3.6/beta for nightly run + 3.5 for PR / merges to
2/edge
branch.